My specific ask for this bug is much much simpler. Most of the token implementations that we have already know what the container is. I am just proposing adding a getter for the field and pulling it up into the SecurityToken interface. I'm also not proposing that we need to use this anywhere in the shindig code.
The specific implementation that I am working on needs extra information from the ContainerConfig.. which is keyed off of the container... which is currently stuck behind the interface. Allowing consumers of the token to get the current container makes adding new container-specific params to the json backing the ContainerConfig very easy. I'm attaching a patch now to clear up what I meant. Please let me know what you think. Thanks! - Cassie On Wed, Oct 1, 2008 at 9:33 AM, Kevin Brown <[EMAIL PROTECTED]> wrote: > On Wed, Oct 1, 2008 at 8:53 AM, Chris Chabot <[EMAIL PROTECTED]> wrote: > > > that would be very welcome ... well that and including the security token > > in > > proxy posts (added security + being able to load container specific > config > > for proxy requests too, like, what http fetcher class to use) > > > Are you referring to makeRequest or the open proxy? I'd be hesitant to > include the security token in open proxy requests due to caching > implications, but it should be passed in makeRequest already. > > > > > > > > On Wed, Oct 1, 2008 at 4:16 PM, Ropu <[EMAIL PROTECTED]> wrote: > > > > > Hi Cassie, im working on the update of the way we user the ST in PHP. > > > > > > Can you elaborate a little more on how will affect the code that uses > de > > > ST? > > > > > > And obviously we need to update the way we generate it in the iframe > url. > > > > > > anything else? > > > > > > thanks > > > > > > ropu > > > > > > On Tue, Sep 30, 2008 at 8:39 PM, Cassie Doll (JIRA) <[EMAIL PROTECTED]> > > > wrote: > > > > > > > Add a new method to SecurityToken - getContainer() > > > > -------------------------------------------------- > > > > > > > > Key: SHINDIG-635 > > > > URL: > https://issues.apache.org/jira/browse/SHINDIG-635 > > > > Project: Shindig > > > > Issue Type: New Feature > > > > Components: Common Components (Java) > > > > Reporter: Cassie Doll > > > > > > > > > > > > I'd like to add a new method to the SecurityToken interface called > > > > getContainer(). This will return the current container that is being > > > > rendered. With the container and the ContainerConfig any consumers of > > the > > > > SecurityToken interface can look up any parameter that they may need. > > > > > > > > Does anybody think this will be a problem? > > > > > > > > -- > > > > This message is automatically generated by JIRA. > > > > - > > > > You can reply to this email to add a comment to the issue online. > > > > > > > > > > > > > > > > > -- > > > .-. --- .--. ..- > > > R o p u > > > > > >
