Overall looks fine, couple of minor comments.

http://codereview.appspot.com/10269/diff/1/5
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/localfile/LocalFileServlet.java
(right):

http://codereview.appspot.com/10269/diff/1/5#newcode37
Line 37: * requests from localhost will be honored.
Add a comment making it obvious that this should only be used in test
environments.

http://codereview.appspot.com/10269/diff/1/5#newcode69
Line 69: in = new BufferedInputStream(new FileInputStream(file),
BUFFER_SIZE);
Use the IOUtils class to do the IO handling, it has built in buffering
and youll have less code.

http://codereview.appspot.com/10269

Reply via email to