Re: svn commit: r732453 [1/3] - in /incubator/shindig/branches/1.0.x-incubating: ./ java/common/ java/common/src/main/java/org/apache/shindig/auth/ java/common/src/main/java/org/apache/shindig/common/ java/common/src/main/java/org/apache/shindig/comm

[Henning Schmiedehausen]

On Wed, Jan 7, 2009 at 23:38, Paul Lindner <plind...@hi5.com> wrote:
> On Jan 7, 2009, at 5:14 PM, Henning Schmiedehausen wrote:
>
>> I  -1 this patch unless you can sufficiently explain why e.g.
>>
>>> -    tokenData = new HashMap<String, String>(5,1);
>>> +    tokenData = Maps.newHashMapWithExpectedSize(5);
>>
>> is better readable to someone with knowledge of the standard Java APIs
>> and no knowledge of Google Collections.
>
> Is it really that hard to understand?  Really?  Some Junior Devs looked at
> that code and easily understood the intent.

Everything needed has been said by Eric. He is smart and correct.

I stand by my -1  I would still appreciate a compelling explanation,
why this is needed.

    Ciao
         Henning