http://codereview.appspot.com/17086/diff/1/2
File
java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java
(right):

http://codereview.appspot.com/17086/diff/1/2#newcode379
Line 379: private static class MethodCaller {
move this to a package-private top-level class, maybe:
DefaultHandlerRegistry is quite long as is

http://codereview.appspot.com/17086/diff/1/2#newcode384
Line 384: private final Constructor<?> requestItemConstructor;
should be Constructor<? extends RequestItem>

http://codereview.appspot.com/17086/diff/1/2#newcode395
Line 395: public MethodCaller(Method method, boolean isRest) throws
NoSuchMethodException {
instead of isRest, use an inner enum;  or just pass in
requestItemFirstParamClass;  or just have some statics with the type
signature of the REST and RPC item constructors, and pass in the whole
type signature array to the constructor

http://codereview.appspot.com/17086

Reply via email to