Message templates are of reduced utility without template expansion as in Activities, but we seem to have overlooked that during the spec proposal phase.
Should we request a spec clarification adding a templateParameters field, or would that be better left as a proposal for the next spec version? http://codereview.appspot.com/20106/diff/1/30 File features/src/main/javascript/features/opensocial-base/jsonmessage.js (right): http://codereview.appspot.com/20106/diff/1/30#newcode44 Line 44: //} If this is not being used, why not remove it? http://codereview.appspot.com/20106/diff/1/20 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java (right): http://codereview.appspot.com/20106/diff/1/20#newcode73 Line 73: "url parameter is not a valid url: " + urlToValidate); This probably belongs in a separate patch. http://codereview.appspot.com/20106/diff/1/15 File java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/MediaItem.java (right): http://codereview.appspot.com/20106/diff/1/15#newcode145 Line 145: void setThumbnailUrl(String url); Missing javadoc. http://codereview.appspot.com/20106/diff/1/11 File java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Person.java (right): http://codereview.appspot.com/20106/diff/1/11#newcode20 Line 20: import org.apache.shindig.social.opensocial.model.EnumUtil; unused import? http://codereview.appspot.com/20106/diff/1/11#newcode35 Line 35: import java.util.EnumSet; unused imports? http://codereview.appspot.com/20106/diff/1/11#newcode251 Line 251: return lookup.get(jsonString); Does this belong in this patch? http://codereview.appspot.com/20106/diff/1/18 File java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java (right): http://codereview.appspot.com/20106/diff/1/18#newcode50 Line 50: Empty diff. http://codereview.appspot.com/20106/diff/1/17 File java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/MessageService.java (right): http://codereview.appspot.com/20106/diff/1/17#newcode53 Line 53: Future<MessageCollection> createMessageCollection(UserId userId, MessageCollection msgCollection, SecurityToken token); Missing javadocs. http://codereview.appspot.com/20106/diff/1/17#newcode55 Line 55: Future<Void> deleteMessageCollection(UserId userId, String msgCollId, SecurityToken token); Add throws SocialSpiException to all these. http://codereview.appspot.com/20106/diff/1/17#newcode102 Line 102: Future<Void> modifyMessage(UserId userId, String msgCollId, String messageId, Message message, SecurityToken token); Missing javadoc. Add throws SocialSpiException to method signature. http://codereview.appspot.com/20106/diff/1/4 File java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java (right): http://codereview.appspot.com/20106/diff/1/4#newcode490 Line 490: return null; All these unimplemented methods should throw a NOT_IMPLEMENTED SocialSpiException, instead of silently doing nothing. http://codereview.appspot.com/20106/diff/1/4#newcode552 Line 552: empty lines http://codereview.appspot.com/20106
