The majority of the source code had already removed trailing
whitespace. Some statistics:
- around 600 java files
- only around 140 java files don't removed trailing whitespace

So, IMHO removing trailing whitespace is the way to go.

WDYT?

Cheers,

Vincent

2009/3/5 Adam Winer <[email protected]>:
> Instead of 2 commits, could you change it to not remove trailing
> whitespaces?  It unnecessarily obfuscates history, especially when
> there's trailing whitespace on non-blank lines.  This is typically an
> option that can be adjusted in an IDE.
>
> -- Adam
>
>
> On Thu, Mar 5, 2009 at 3:21 PM, Vincent Siveton <[email protected]> wrote:
>> Hi Adam,
>>
>> 2009/3/5 Adam Winer <[email protected]>:
>>> I see a lot of whitespace changes with each submission, apparently
>>> around blank lines.  Any way you could avoid making these changes?
>>> It's much harder to read diffs like this.
>>
>> Yeah, my IDE removes trailing whitespaces. I will do 2 commits next time.
>>
>> Cheers,
>>
>> Vincent
>>
>

Reply via email to