Re: svn commit: r750433 - in /incubator/shindig/trunk/java/gadgets/src: main/java/org/apache/shindig/gadgets/parse/nekohtml/ test/java/org/apache/shindig/gadgets/parse/nekohtml/ test/resources/org/apache/shindig/gadgets/parse/nekohtml/

[Louis Ryan]

I think it would have been OK to modify the expected value for this test.

On Fri, Mar 6, 2009 at 3:05 AM, Vincent Siveton
<vincent.sive...@gmail.com>wrote:

> Hi Louis,
>
> 2009/3/5 Louis Ryan <lr...@google.com>:
> > Vincent,
> >
> > Was the test failure in a unit-test or the browser. I believe always
> > escaping & should work in all major browsers.
>
> Having this logic in NekoSimplifiedHtmlParser#appendAttributeValue()
> and NekoSerializer#printAttributeValue()
>        } else if (c == '&') {
>          builder.append("&amp;");
>
> Failed tests:
>
>  
> enforceImageSrcProxied(org.apache.shindig.gadgets.render.SanitizedRenderingContentRewriterTest)
>
>
> enforceImageSrcProxied(org.apache.shindig.gadgets.render.SanitizedRenderingContentRewriterTest)
>  Time elapsed: 0 sec  <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...www.evil.com%2Fx.js&[gadget=www.example.org
> %2Fgadget.xml&fp=45508&sanitize=1&]rewriteMime=image/*"...>
> but was:<...www.evil.com%2Fx.js&[amp;gadget=www.example.org
> %2Fgadget.xml&amp;fp=45508&amp;sanitize=1&amp;]rewriteMime=image/*"...>
>        at org.junit.Assert.assertEquals(Assert.java:123)
>        at org.junit.Assert.assertEquals(Assert.java:145)
>        at
> org.apache.shindig.gadgets.render.SanitizedRenderingContentRewriterTest.enforceImageSrcProxied(SanitizedRenderingContentRewriterTest.java:177)
>
> HTH
>
> Vincent
>