On Mon, Mar 9, 2009 at 11:59 AM, Vincent Siveton <[email protected]> wrote: > Hi Adam, > > 2009/3/9 Adam Winer <[email protected]>: >>> Log: >>> o added undeclared dependencies given by mvn dependency:analyze >>> o added aopalliance dependency which is used by guice >> >> Are these JARs we do directly depend on, but haven't directly defined? >> Or JARs we just implicitly depend on? For aopalliance, I think it's > > Yes. > You could always run mvn dependency:analyze to see what happen before > and after this commit. > Please read [1] for more information.
Cool, makes sense. Thanks for the pointers. >> the latter, in which case I don't see the benefit in explicitly >> defining the dependency - it just makes it easier to have multiple >> versions of the same library referenced by our builds (e.g., if guice >> bumps its version dependency). > > As I commented in the main pom, aopalliance is not properly defined as > dependency in the guice pom [2]. They used <dependencyManagement/> tag > instead of <dependency/> tag. > > Cheers, > > Vincent > > [1] http://maven.apache.org/plugins/maven-dependency-plugin/analyze-mojo.html > [2] > http://repo2.maven.org/maven2/com/google/code/guice/guice/1.0/guice-1.0.pom >
