Made json output application/json
http://codereview.appspot.com/28042/diff/19/1020 File java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java (right): http://codereview.appspot.com/28042/diff/19/1020#newcode85 Line 85: public static final String CONTENT_TYPE = "CONTENT_TYPE"; On 2009/03/14 00:17:18, beaton wrote:
I can't find this used anywhere.
Removed. http://codereview.appspot.com/28042/diff/19/1020#newcode197 Line 197: return contentType.trim().toLowerCase(); On 2009/03/14 00:17:18, beaton wrote:
Might be nice to have a standard utility function for parsing these
somewhere.
(There is another version of this function in HttpResponse.java, getAndUpdateEncoding. That's a slightly more robust parser, but not
by much.) Leaving for a later refactoring. Added comment http://codereview.appspot.com/28042/diff/19/1014 File java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java (right): http://codereview.appspot.com/28042/diff/19/1014#newcode128 Line 128: bodyReader = servletRequest.getReader(); On 2009/03/14 00:17:18, beaton wrote:
This code will need changing when we add body signature checking. I
think the
strategy might end up being:
- filter calls getInputStream, reads byte array, checks signature - filter replaces input-stream and/or reader with the byte array
Servlet wrapper now takes care of this. http://codereview.appspot.com/28042/diff/19/1006 File java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/AbstractLargeRestfulTests.java (right): http://codereview.appspot.com/28042/diff/19/1006#newcode131 Line 131: //req.setContentType() On 2009/03/14 00:17:18, beaton wrote:
can delete this
Done. http://codereview.appspot.com/28042
