Thanks both for the review. Updated as: http://codereview.appspot.com/32042
On Thu, Mar 26, 2009 at 9:58 AM, Adam Winer <[email protected]> wrote: > On Thu, Mar 26, 2009 at 9:01 AM, <[email protected]> wrote: > > It might be nice to have some tests. > > Shindig's Uri code already has a bunch of resolve() tests. But we > could use some tests of ".." and "." functionality, which I don't > believe are included in the existing UriTest. > > > java.net.Uri has the following: > > > > > http://www.google.com/codesearch/p?hl=en#TTY8xLpnKOE/test/java/net/URI/Test.java&q=java.net.uri%20test%20lang:java > > > > > > http://codereview.appspot.com/27117/diff/1/2 > > File java/common/src/main/java/org/apache/shindig/common/uri/Uri.java > > (right): > > > > http://codereview.appspot.com/27117/diff/1/2#newcode194 > > Line 194: Collections.addAll(mergePath, otherPath.split("/")); > > Suggest using StringUtils.splitPreserveAllTokens or StringUtils.split > > (non-regex). > > > > I *think* preserveAllTokens will avoid the if statement below... > > > > http://codereview.appspot.com/27117 > > >
