Reviewers: chabotc, panjie,

Description:
When using makeRequest for post data:
var data = {'param':'123&456'};
params[gadgets.io.RequestParameters.POST_DATA] =
gadgets.io.encodeValues(data);
gadgets.io.makeRequest('http://example.com', callback, params);

param will be truncated to 'param=123' in php-shindig.
Java-shindig works well.



Please review this at http://codereview.appspot.com/28119

Affected files:
  php/src/gadgets/ProxyBase.php


Index: php/src/gadgets/ProxyBase.php
===================================================================
--- php/src/gadgets/ProxyBase.php       (revision 759010)
+++ php/src/gadgets/ProxyBase.php       (working copy)
@@ -60,9 +60,9 @@
       }
       $postData = '';
       if ($data) {
-        $data = urldecode($data);
         $entries = explode('&', $data);
         foreach ($entries as $entry) {
+          $entry = urldecode($entry);
           $parts = explode('=', $entry);
           // Process only if its a valid value=something pair
           if (count($parts) == 2) {


Reply via email to