http://codereview.appspot.com/28158/diff/1/12 File java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/FlashTagHandler.java (right):
http://codereview.appspot.com/28158/diff/1/12#newcode80 Line 80: err.setTextContent("Failed to process os:Flash tag: " + re.getMessage()); Should we sanitize message? Adam mentioned the sanitizer doesn't look into text nodes for HTML markup. http://codereview.appspot.com/28158/diff/1/12#newcode180 Line 180: processor.evaluate(attr.getNodeValue(), String.class, attr.getNodeValue())); I think using AbstractTagHandler.getValueFromTag() here would be clearer http://codereview.appspot.com/28158
