On Mon, Apr 13, 2009 at 10:26 AM, Audrey Tang (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/SHINDIG-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698447#action_12698447 > ] > > Audrey Tang commented on SHINDIG-812: > ------------------------------------- > > > I can't reproduce it in Socialtext's container. Is there a minimal > sample case I can test against?
I see the resizing on www.orkut.com profile pages right now (with Emote, for example), though I expect they'll patch that. The simple workaround I'd recommend is ignoring resize events that are less than some delta (e.g. a few pixels). > That is true and is a bug. > > > I'm sorry, but my patch was against an older tree and the "!==" call > wasn't there, so my patch simply turned != to ==: > > https://issues.apache.org/jira/secure/attachment/12396810/adjustHeight-on-resize-3.diff > > > If !== is desired, I'd be happy to have it be !==. > > I agree oldHeight2 is insufficiently descriptive. I'll work on a > revised patch when another round of tuits are available. > > Cheers, > Audrey > > > >> [PATCH] Attach gadgets.window.adjustHeight to the onresize event >> ---------------------------------------------------------------- >> >> Key: SHINDIG-812 >> URL: https://issues.apache.org/jira/browse/SHINDIG-812 >> Project: Shindig >> Issue Type: Improvement >> Components: Javascript >> Affects Versions: trunk >> Reporter: Audrey Tang >> Assignee: Vincent Siveton >> Priority: Minor >> Fix For: trunk >> >> Attachments: adjustHeight-on-resize-2.diff, >> adjustHeight-on-resize-3.diff, adjustHeight-on-resize.diff >> >> >> The patch below implements the commented TODO functionality of having >> gadgets adjustHeight when the browser window resizes. >> --- trunk/features/dynamic-height/dynamic-height.js >> +++ trunk/features/dynamic-height/dynamic-height.js >> @@ -134,11 +134,19 @@ >> oldHeight = newHeight; >> gadgets.rpc.call(null, "resize_iframe", null, newHeight); >> } >> + >> + gadgets.window.resizeAgain = function () { >> + gadgets.window.adjustHeight(opt_height);+ };+ >> + if (window.addEventListener) { >> + window.addEventListener("resize", gadgets.window.resizeAgain, >> false); >> + } >> + else if (window.attachEvent) { >> + window.attachEvent("resize", gadgets.window.resizeAgain); >> + } >> }; >> }()); >> >> // Alias for legacy code >> var _IG_AdjustIFrameHeight = gadgets.window.adjustHeight; >> - >> -// TODO Attach gadgets.window.adjustHeight to the onresize event >> - > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
