ContentRewriter "cleanup": separate GadgetRewriter and RequestRewriter, etc.

Tue, 14 Apr 2009 18:05:44 -0700 

Reviewers: shindig.remailer, etnu00,

Message:
ContentRewriter supports both rewriting of gadgets and of HTTP requests.
 In practice, most rewriters are only one or the other.  There's also a
RewriterResults class that looked to introduce cacheability definitions,
but was largely ignored in practice.

This patch splits ContentRewriter into GadgetRewriter and
RequestRewriter, renames classes accordingly, and eliminates
RewriterResults.  ContentRewriterRegistry now only handles request
rewriting (and is named RequestRewriterRegistry).



Please review this at http://codereview.appspot.com/41063

Affected files:
M java/gadgets/src/main/java/org/apache/shindig/gadgets/http/CacheKeyBuilder.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/render/HtmlRenderer.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderModule.java D java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingContentRewriter.java A + java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java D java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizedRenderingContentRewriter.java A + java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizedRenderingGadgetRewriter.java A + java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizedRenderingRequestRewriter.java D java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CSSContentRewriter.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CaptureRewriter.java D java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ContentRewriter.java D java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ContentRewriterRegistry.java A + java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java D java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/DefaultContentRewriterRegistry.java A + java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/DefaultRequestRewriterRegistry.java A java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/GadgetRewriter.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HTMLContentRewriter.java D java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/NoOpContentRewriter.java D java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/PipelineDataContentRewriter.java A + java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/PipelineDataGadgetRewriter.java A java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RequestRewriter.java A + java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RequestRewriterRegistry.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java D java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriterResults.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/FlashTagHandler.java M java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java M java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java D java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingContentRewriterTest.java A + java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java D java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizedRenderingContentRewriterTest.java A + java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizedRenderingGadgetRewriterTest.java A + java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizedRenderingRequestRewriterTest.java D java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/AppendingRewriter.java M java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/BaseRewriterTestCase.java D java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CSSContentRewriterTest.java A + java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriterTest.java M java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/DefaultContentRewriterRegistryTest.java M java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/HTMLContentRewriterTest.java D java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/PipelineDataContentRewriterTest.java A + java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/PipelineDataGadgetRewriterTest.java M java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HttpRequestHandlerTest.java M java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ServletTestFixture.java

Reply via email to