I'd throw some setters on BasicHttpFetcher, and call those setters from a Guice Provider (instead of just binding HttpFetcher directly to BasicHttpFetcher). Patches welcome for the first half.
On Fri, Apr 17, 2009 at 9:52 AM, Jordan Zimmerman <[email protected]> wrote: > *bump* > > This needs a solution. > > Jordan Zimmerman > Principal Software Architect > 831.647.4712 > 831.214.2990 (cell) > [email protected] > > SHOP*COMTM > Shop Smart, Save Big(tm) > www.shop.com > > -----Original Message----- > From: Jordan Zimmerman [mailto:[email protected]] > Sent: Thursday, April 16, 2009 3:20 PM > To: [email protected] > Subject: RE: BasicHttpFetcher.CONNECT_TIMEOUT_MS > > Doh - the second hard-cdoe is the unused max bytes > > Jordan Zimmerman > Principal Software Architect > 831.647.4712 > 831.214.2990 (cell) > [email protected] > > SHOP*COMTM > Shop Smart, Save Big(tm) > www.shop.com > > > -----Original Message----- > From: Jordan Zimmerman [mailto:[email protected]] > Sent: Thursday, April 16, 2009 3:16 PM > To: [email protected] > Subject: BasicHttpFetcher.CONNECT_TIMEOUT_MS > > The timeout in BasicHttpFetcher is hard-coded to 5 seconds. It would be > much better to have this be changeable. Yes? > > It could be done by adding a new method to HttpFetcher - something like > setProperties() or setConstants(). There are two hard coded values now > (timeout and the currently unused connection timeout). This new method > would allow changing of either of these values and any future values. > > Alternatively, it could be done via Guice named parameters. But that has > the downside of making it difficult to change as the HttpFetcher > singleton is created very early by the DefaultGuiceModule. > > Jordan Zimmerman > Principal Software Architect > 831.647.4712 > 831.214.2990 (cell) > [email protected] > > SHOP*COMTM > Shop Smart, Save Big(tm) > www.shop.com > > > > This message (including any attachments) is intended only for > the use of the individual or entity to which it is addressed and > may contain information that is non-public, proprietary, > privileged, confidential, and exempt from disclosure under > applicable law or may constitute as attorney work product. > If you are not the intended recipient, you are hereby notified > that any use, dissemination, distribution, or copying of this > communication is strictly prohibited. If you have received this > communication in error, notify us immediately by telephone and > (i) destroy this message if a facsimile or (ii) delete this > message > immediately if this is an electronic communication. > > Thank you. >
