The import order doesnt look quite right on some of these classes, but it didnt look right to start with ?
also, I am slightly concerned about binding the SPI to javax.servlet. Just a gut feeling that binding the protocol impl all the way down the stack means you cant use another protocol... but thats probably just unfounded as this is all about http. http://codereview.appspot.com/45044/diff/1/22 File java/gadgets/src/main/java/org/apache/shindig/gadgets/http/InvalidationHandler.java (right): http://codereview.appspot.com/45044/diff/1/22#newcode31 Line 31: import javax.servlet.http.HttpServletResponse; I have the following import order, as configured some time last year when the code style was agreed. 8=javax 7=java 6=org 5=org.apache.abdera 4=org.apache.shindig 3=net 2=junit 1=com 0=com.google 0 is the first I dont think either before or after the patch is correct. (might be wrong about that) http://codereview.appspot.com/45044
