Shallow copy is the desired result - but it was breaking a templates use case, so it was temporarily changed to returning the reference.
This broke a unit test. It can probably be rolled back for a quick fix. For longer term, the patch here: http://codereview.appspot.com/59046/show restores shallow copy functionality and fixes the templating's dependence on getting a reference. On Tue, May 5, 2009 at 5:51 PM, Brian Eaton <[email protected]> wrote: > The shindig build is failing because of svn revision 771945 [1]. The > old code was creating a shallow copy of dataSets. The new code is > returning a reference. There is a test case that explicitly verifies > that a copy is returned. > > What's the desired behavior here? Reference, shallow copy, or deep copy? > > I've got a simple patch that restores the shallow copy, just not sure > it's what you intended. > > [1] > http://svn.apache.org/viewvc/incubator/shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js?r1=770941&r2=771945&diff_format=h > > Cheers, > Brian > > ---------- Forwarded message ---------- > From: Apache Hudson Server <[email protected]> > Date: Tue, May 5, 2009 at 11:08 AM > Subject: Build failed in Hudson: Shindig ยป Apache Shindig Features #704 > To: [email protected] > > > See > http://hudson.zones.apache.org/hudson/job/Shindig/org.apache.shindig$shindig-features/704/ > > ------------------------------------------ > [INFO] > ------------------------------------------------------------------------ > [INFO] Building Apache Shindig Features > [INFO] task-segment: [clean, install] > [INFO] > ------------------------------------------------------------------------ > [INFO] [clean:clean] > [INFO] Deleting file set: > /export/home/hudson/hudson/jobs/Shindig/workspace/trunk/features/target > (included: [**], excluded: []) > [INFO] [enforcer:enforce {execution: enforce-java}] > [INFO] [remote-resources:process {execution: default}] > [INFO] [resources:resources] > [INFO] Using 'UTF-8' encoding to copy filtered resources. > [INFO] Copying 1020 resources to features > [INFO] Copying 4 resources > [INFO] [yuicompressor:compress {execution: default}] > [INFO] nb warnings: 0, nb errors: 0 > [INFO] [compiler:compile] > [INFO] No sources to compile > [INFO] [resources:testResources] > [INFO] Using 'UTF-8' encoding to copy filtered resources. > [INFO] Copying 33 resources to features > [INFO] Copying 4 resources > [INFO] [compiler:testCompile] > [INFO] No sources to compile > [INFO] [surefire:test] > [INFO] Surefire report directory: > /export/home/hudson/hudson/jobs/Shindig/workspace/trunk/features/target/surefire-reports > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > There are no tests to run. > > Results : > > Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 > > [HUDSON] Recording test results > [INFO] [jsunit2:jsunit-test {execution: default}] > [HUDSON] Archiving > /export/home/hudson/hudson/jobs/Shindig/workspace/trunk/features/pom.xml > to > /export/home/hudson/hudson/jobs/Shindig/modules/org.apache.shindig$shindig-features/builds/2009-05-05_18-03-16/archive/org.apache.shindig/shindig-features/1.1-SNAPSHOT/pom.xml > [INFO] > ------------------------------------------------------------------------ > [ERROR] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] There have been 0 errors and 1 failures testing JavaScript > [INFO] > ------------------------------------------------------------------------ > [INFO] For more information, run Maven with the -e switch > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 5 minutes 27 seconds > [INFO] Finished at: Tue May 05 18:08:54 UTC 2009 > [INFO] Final Memory: 55M/275M > [INFO] > ------------------------------------------------------------------------ >
