http://codereview.appspot.com/53052/diff/2001/3007 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java (right):
http://codereview.appspot.com/53052/diff/2001/3007#newcode243 Line 243: StringBuffer output = new StringBuffer(); On 2009/05/08 20:29:53, louiscryan wrote:
Can use JsonSerializer.appendString to do the escaping.
Done http://codereview.appspot.com/53052/diff/2001/3007#newcode261 Line 261: return '"' + output.toString().replace("</script>", "</scri\" + \"pt>") + '"'; On 2009/05/08 20:42:15, etnu00 wrote:
You don't need any hacks like this for closing script tags. Just
replacing
</script> with <\/script> is sufficient (and the 'proper' way).
Good point. Though this doesn't matter any longer with the use of JsonSerializer. http://codereview.appspot.com/53052/diff/2001/3005 File java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/LibraryTagRegistryTest.java (right): http://codereview.appspot.com/53052/diff/2001/3005#newcode82 Line 82: reg.getHandlerFor(foo); On 2009/05/08 20:29:53, louiscryan wrote:
I would have expected a test to make sure that I got the right
TagHanlder
instance here.
Added http://codereview.appspot.com/53052
