Changing the line endings will make lots of social rest/rpc end point tests fail since they do a text blob match, is there really no exclude_rewrite=*.php flag that can be set somewhere in that mysterious maven configuration?
On Wed, May 13, 2009 at 3:55 PM, Ian Boston <[email protected]> wrote: > Chris, > you might want to look at this, > If the assemblies are built on a unix platform, png gif etc files were > getting modified. > On a windows platform all files were getting modified. > IMHO there isn't much point in changing line endings unless we are going to > do a dos bundle and a separate unix bundle. > > The only downside is that if built on a windows machine the release will > have windows line endings. > > WDYT? > Ian > > > BTW, same goes for the source bundle where I have opted to keep the same > line endings. > > > On 13 May 2009, at 14:49, [email protected] wrote: > > Author: ieb >> Date: Wed May 13 13:49:19 2009 >> New Revision: 774369 >> >> URL: http://svn.apache.org/viewvc?rev=774369&view=rev >> Log: >> Removed unix line endings from the php artifact as this incorrectly >> modifies binary files, and would not be any better on windows platform if >> built ona unix platform. >> >> Modified: >> >> incubator/shindig/branches/1.0.x-incubating/assembly/src/main/assembly/php.xml >> >> Modified: >> incubator/shindig/branches/1.0.x-incubating/assembly/src/main/assembly/php.xml >> URL: >> http://svn.apache.org/viewvc/incubator/shindig/branches/1.0.x-incubating/assembly/src/main/assembly/php.xml?rev=774369&r1=774368&r2=774369&view=diff >> >> ============================================================================== >> --- >> incubator/shindig/branches/1.0.x-incubating/assembly/src/main/assembly/php.xml >> (original) >> +++ >> incubator/shindig/branches/1.0.x-incubating/assembly/src/main/assembly/php.xml >> Wed May 13 13:49:19 2009 >> @@ -64,7 +64,6 @@ >> <exclude>NOTICE</exclude> >> <exclude>README</exclude> >> </excludes> >> - <lineEnding>unix</lineEnding> >> </fileSet> >> <fileSet> >> <outputDirectory>shindig-${pom.version}-php</outputDirectory> >> @@ -97,7 +96,6 @@ >> <exclude>*.sh</exclude> >> <exclude>*.bat</exclude> >> </excludes> >> - <lineEnding>unix</lineEnding> >> </fileSet> >> <!-- Using the temp container.php created by Maven using Antrun plugin >> to rewrite >> default configuration to release structure --> >> @@ -109,7 +107,6 @@ >> <exclude>**/.git/**</exclude> >> <exclude>**/.svn/**</exclude> >> </excludes> >> - <lineEnding>unix</lineEnding> >> </fileSet> >> </fileSets> >> </assembly> >> >> >> >
