Thanks John, If you don't commit it today, I will. On Thu, Jun 25, 2009 at 2:30 PM, John Hjelmstad <[email protected]> wrote:
> Thanks for your continued comments- > I've created a new patch removing document.postMessage(...) from the code. > I agree that Opera8 usage is so tiny as to be deemed nonexistent. > > For the moment, I'm keeping the rest though. Much as I'd like to get rid of > unregisterX(...), I'm seeing quite a few references to it within Google's > usage of the library. None are particularly problematic: mostly removal > would result in test breakages and a few compilation problems. But I'd > prefer to do this in a separate process. This set of changes is big enough. > > I'm personally on the fence about callSameDomain(...) but will keep it in > as well for the moment per Evan's comments. > > New patch: http://codereview.appspot.com/88069 > > I'll keep this patch up as a nice UI for any further comments, but will > commit it soon. > > --John > > On Wed, Jun 24, 2009 at 5:01 PM, Paul Lindner <[email protected]> wrote: > >> Funny, I found the serialize/deserialize an issue because people >> developing might pass js objects back and forth, but I say let it in if Evan >> says it's useful. >> Can we get this patch committed now? Are we all in agreement? >> >> >> On Fri, Jun 19, 2009 at 2:15 PM, <[email protected]> wrote: >> >>> >>> http://codereview.appspot.com/63209/diff/1/2 >>> File features/src/main/javascript/features/rpc/rpc.js (right): >>> >>> http://codereview.appspot.com/63209/diff/1/2#newcode339 >>> Line 339: function callSameDomain(target, rpc) { >>> On 2009/06/11 09:32:21, etnu00 wrote: >>> >>>> This really belongs in a file shared by 'slow' methods. >>>> >>> window.postMessage is as >>> >>>> fast as callSameDomain, so we can ignore this entirely when we are >>>> >>> using a >>> >>>> browser that doesn't suck. >>>> >>> >>> Same domain calls don't have to serialize the JSON and should be >>> significantly faster, especially for larger data sets. I'd like to keep >>> some variant of this around. >>> >>> >>> http://codereview.appspot.com/63209 >>> >> >> >
