On Wed, Jul 15, 2009 at 8:52 AM, <le...@google.com> wrote: > This implementation seems to define the variable for the entire > invocation scope of a template (rather than scoped to the parent element > of the <osx:Variable> tag as was initially proposed on the discussion > thread.
This implements Christopher Cole's spec suggestion of using My (see goosemanjack's message from June 30) . I see the confusion: you said "I like this idea", responding to Lane's message, but temporally after Christopher's e-mail. So I thought you were +1'ing Christopher's proposal, and when I said "I agree, this is good", I meant Christopher's suggestion. > http://codereview.appspot.com/91118/diff/1/39 > File > java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/VariableTagHandler.java > (right): > > http://codereview.appspot.com/91118/diff/1/39#newcode48 > Line 48: processor.getTemplateContext().getMy().put(key, value); > I think putting the variable into Cur is more appropriate than My, since > My is used to access XML attributes and Cur is used to access runtime > data. It's too restrictive to think of "My" in that way. It's just "the scope that is limited to a tag invocation". > > http://codereview.appspot.com/91118 >
