Since this feature is a "MAY", I would like to add another switch to shindig.properties: shindig.content-rewrite.only-allow-excludes
This will only allow the gadget author to specify values for "exclude-url" or "exclude-urls", only allow subtractions from "include-tags", and to not increase "expires" above the default value. It would disallow: "include-url", "include-urls". Rationale: As the host of the gadget server, I have decided what URLs and types and ttls are suitable for my installation. I do not want a gadget author to be able to increase any of those values, but should the gadget author decide they don't want content rewritten, or a shorter caching, that would be allowed. Comments? Jon -----Original Message----- From: Weygandt, Jon [mailto:[email protected]] Sent: Monday, October 05, 2009 10:34 AM To: [email protected] Subject: content-rewrite feature not implemented per OpenSocial 0.9 spec Per the OS v0.9 spec: http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/Gadget s-API-Specification.html#rfc.section.3.4 The include-url, exclude-url are singular, and the parameters may be repeated. Plus "*" is a valid pattern. Plus there are minify-* parameters Per the code in ContentRewriterFeature.java include-urls, exclude-urls are plural, and there can be only one. Plus the pattern is fed to Pattern.compile, so "*" throws an exception. Unless people feel strongly the spec is incorrect, I can put together a patch that will keep the plural versions for backward compatibility, but also properly honors the singular versions per the spec. Perhaps even add the "minify-*" options. Jon
