http://codereview.appspot.com/129072/diff/22/1001 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java (right):
http://codereview.appspot.com/129072/diff/22/1001#newcode114 Line 114: String key = HashUtil.rawChecksum(content.getContent().getBytes()); If serialization is significantly faster than cajoling we can worry about the key later as a TODO. I would put a more efficient key generation method on MutableContent that does not require large buffer allocations for serialized documents. On 2009/10/12 22:09:54, johnfargo wrote:
Two comments on selection of key: 1) can you augment DocumentGadgetRewriter to compute one from its
input,
augmenting during the rewriting pass? that avoids the serialization/deserialization set you're doing here. 2) DGR could/should also include some notion of Caja version in its
key
computation, to avoid stale entries in the event that CacheProvider
might offer
a distributed cache.
http://codereview.appspot.com/129072
