Thanks for the comments, Jon. I'll update a patch shortly that incorporates your fixes. What I haven't done (locally) yet is make RenderingGadgetRewriter methods protected. What was the rationale there again? Seems reasonable, just curious.
http://codereview.appspot.com/143046/diff/80/1043 File java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java (right): http://codereview.appspot.com/143046/diff/80/1043#newcode177 Line 177: public List<FeatureResource> getFeatureResources( Updated patch forthcoming. I thought this logic was weird too when I ported it over. http://codereview.appspot.com/143046/diff/80/1033 File java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java (right): http://codereview.appspot.com/143046/diff/80/1033#newcode185 Line 185: throw new RuntimeException(e); Agreed... I'll merge this in. http://codereview.appspot.com/143046
