okay, fixed all noted issues. I think we're good to go..
http://codereview.appspot.com/149041/diff/3021/2009 File java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/GadgetOAuthTokenStore.java (right): http://codereview.appspot.com/149041/diff/3021/2009#newcode75 java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/GadgetOAuthTokenStore.java:75: * - Information from the OAUth Fetcher config to determine if owner pages are secure fixed On 2009/11/09 19:49:15, beaton wrote:
OAUth -> OAuth
http://codereview.appspot.com/149041/diff/3021/2009#newcode116 java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/GadgetOAuthTokenStore.java:116: securityToken.getOwnerId().equals(securityToken.getViewerId())) { fixed On 2009/11/09 19:49:15, beaton wrote:
we lost a check for securityToken.getOwnerId() != null. Maybe swap
the order
here to avoid any potential null pointer exception?
http://codereview.appspot.com/149041/diff/3021/2010 File java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthFetcherConfig.java (right): http://codereview.appspot.com/149041/diff/3021/2010#newcode38 java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthFetcherConfig.java:38: private static boolean viewerAccessTokensEnabled = false; true, true. fixed. On 2009/11/09 19:49:15, beaton wrote:
shouldn't be static, not thread safe. Make it private final member
variable
instead.
http://codereview.appspot.com/149041
