Thanks Paul, change made and tested. Anyone else have commentary? I'd love
some input, even if only on GadgetHtmlParser.java, where the bulk of
Neko-related potential side effects (given that Neko is still marked as
default parser) are introduced.

--j

On Mon, Dec 7, 2009 at 12:25 AM, <[email protected]> wrote:

> Didn't have time to deeply look at this.  Only obvious thing I noted is
> that the diff lib should be test scope.
>
>
>
> http://codereview.appspot.com/157161/diff/3092/2084
> File java/gadgets/pom.xml (right):
>
> http://codereview.appspot.com/157161/diff/3092/2084#newcode133
> java/gadgets/pom.xml:133: <artifactId>diff_match_patch</artifactId>
> This should be <scope>test</scope> so we don't include this in the
> deployed artifacts.
>
>
> http://codereview.appspot.com/157161
>

Reply via email to