How does this work for jstl 1.1 vs 1.2? AFAIK only glassfish inlcudes 1.2. The jsecurity jsps are using jsp 2.1 and jstl 1.2 syntax.
I haven't tested this in a while, but I suspect that moving to servlet 2.4 will result in some breakage here. I'll review this next week and see what I can find. Paul On Sun, Dec 20, 2009 at 5:26 AM, Dave <[email protected]> wrote: > That's the right thing to do, but does it work on all the Tomcat > versions that we want Shindig example server to run on? Seems to me, > Tomcat (or at least older versions) do not include JSTL. > > - Dave > > > On Sun, Dec 20, 2009 at 2:29 AM, Henry Saputra <[email protected]> > wrote: > > Since JSTL needs to be provided by servlet container, the jstl dependency > > could be changed to: > > > > <dependency> > > <groupId>javax.servlet</groupId> > > <artifactId>jstl</artifactId> > > <version>1.2</version> > > <scope>provided</scope> > > </dependency> > > > > - Henry > > > > On Thu, Dec 17, 2009 at 12:30 PM, Paul Lindner <[email protected]> > wrote: > > > >> jstl is only needed for jsp taglib support that is used for the sample > >> login/auth pieces for three-legged oauth. jstl is needed to work with > >> jsecurity (now Apache Shiro) > >> > >> For specific changes please see the commits referenced below. It > appears > >> that jakarta-taglibs project is stalled, so I'm not sure where we can > get > >> equivalent functionality. Here's the bug for that. > >> > >> https://issues.apache.org/bugzilla/show_bug.cgi?id=45197 > >> > >> Might we be able to pull something from tomcat? > >> > >> commit b57b8b63b4f5f3face978d718ee6cdc840d8fdb0 > >> Author: lindner <lind...@13f79535-47bb-0310-9956-ffa450edef68> > >> Date: Sun Nov 8 08:03:50 2009 +0000 > >> > >> SHINDIG-1221 | Rome 1.0 Upgrade / get jstl from sun java2 repo > >> > >> > >> git-svn-id: > >> > >> > https://svn.apache.org/repos/asf/incubator/shindig/tr...@83384513f79535-47bb-0310-9956-ffa450edef68 > >> > >> commit 4a9018e7809c7f0fc44dc9ff26bfc3701be37ff9 > >> Author: lindner <lind...@13f79535-47bb-0310-9956-ffa450edef68> > >> Date: Wed Mar 25 23:12:30 2009 +0000 > >> > >> SHINDIG-994 | Add sample authn/authz layer to 3 legged OAuth, bumps > >> oauth-core/jetty/servlet-api jars > >> > >> > >> git-svn-id: > >> > >> > https://svn.apache.org/repos/asf/incubator/shindig/tr...@75846213f79535-47bb-0310-9956-ffa450edef68 > >> > >> > >> On Thu, Dec 17, 2009 at 12:14 PM, Dave <[email protected]> wrote: > >> > >> > JSTL is referenced in the Shindig/Java Project Maven POM as a > >> > dependency like so: > >> > > >> > <dependency> > >> > <groupId>javax.servlet</groupId> > >> > <artifactId>jstl</artifactId> > >> > <version>1.2</version> > >> > </dependency> > >> > > >> > And a CDDL licensed version of JSTL is pulled from Java.net, see this > >> > comment: > >> > > >> > <!-- for jstl-1.2 for now.. --> > >> > <repository> > >> > <id>java.net</id> > >> > <url>http://download.java.net/maven/2/</url> > >> > </repository> > >> > > >> > After doing a search of the codebase, it appears to me that the ONLY > >> > reasons that JSTL is included are two JSP files in the Server: > >> > > >> > login.jsp > >> > authorize.jsp > >> > > >> > Does anybody know if there is any other usage of JSTL or JSTL classes > >> > in Shindig? > >> > > >> > Thanks, > >> > - Dave > >> > > >> > > >
