Hi Henry: thanks for the comment. It's true that we could drop the "===true") but I prefer it this way to be as precise as possible about the checked value (since we inject __isgadget=true verbatim).
Cheers, John On Thu, Jan 21, 2010 at 11:36 AM, <[email protected]> wrote: > some small comment. > > > http://codereview.appspot.com/186253/diff/1/4 > File features/src/main/javascript/features/rpc/rpc.js (right): > > http://codereview.appspot.com/186253/diff/1/4#newcode618 > features/src/main/javascript/features/rpc/rpc.js:618: if > (window['__isgadget'] === true) { > We could just check: > if(window['__isgadget']) { > > which I think will check for both true and undefined > > > http://codereview.appspot.com/186253/show >
