Wrong multi-line splitting of long string constant in wpm RPC transport
-----------------------------------------------------------------------
Key: SHINDIG-1196
URL: https://issues.apache.org/jira/browse/SHINDIG-1196
Project: Shindig
Issue Type: Bug
Components: Javascript
Reporter: Ivan Zuzak
Priority: Minor
In features/src/main/javascript/features/rpc/wpm.transport.js a long string is
split between two lines using string concatenation like so:
gadgets.error("No relay set (used as window.postMessage targetOrigin)" +
+ ", cannot send cross-domain message");
However, this is wrong and produces the following output in nightly Chromium
and Firefox:
""No relay set (used as window.postMessage targetOrigin)NaN"
The proper way to concatenate strings is to use a single "+" character like
this:
gadgets.error("No relay set (used as window.postMessage targetOrigin)" +
", cannot send cross-domain message");
which produces the correct output. I've attached a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
