Am 29.11.2010 09:34, schrieb nap: > Hi, > > On Sun, Nov 28, 2010 at 11:15 PM, Hartmut Goebel > <[email protected] <mailto:[email protected]>> wrote: > > Am 25.11.2010 09:52, schrieb nap: >> >> For the "properties" dict, it look better wil a uniq line than >> with multiple lines. It look more clear I think. I'm not for the >> "80 characters max" rule avery where. It's only when it's apply >> that when it's not. And for properties it's more clear when it's >> in one line. > Esp. for the properties I do not agree. In some modules, these are > lines and lines of unstructured text. Hard to read, hard to what > one is searching for. > > what do you mean by unstructured text? For properties? Sorry, I meant unstructured code/data. Yes, the properties in e.g. host.py >> >> comments instead of docstrings, >> >> Yes, this one I know. I do nto like docstrings. I really stry, but >> somethign that is between function prototype and code is not a good >> thing for me. I came from C, and I see code like : > > Well, but shinken is a Python program :-) Even if you personally > dislike docstrings, you should rethink this. Python programmers > love dostrings and using them will be some kind of marketing ;-) > > Yes it's true. But it will make C coders hate even more the code, and > most of monitoring guys are from C in the "Nagios world" ;) I you try to address C coders, shinken will get a C program written in Python syntax. If you want to get a pythonic Python program there is less sense in attracting C coders. > But let try the docstrings. After all, we can also try a tool like > Sphinx and some people will like to use it, and so will begin to hack > the code. And if that make Python guys look at the code, it's good > after all. Using Sphinx is a good decision :-)
[... properties ...] > The code will be quite long after that, but it's another problem. Yes, this is a drawback. But /maybe /this a place we have to think about a different approach. I did not yet to have a deep enough understanding of the code, though. -- Schönen Gruß - Regards Hartmut Goebel Dipl.-Informatiker (univ.), CISSP, CSSLP Goebel Consult Spezialist für IT-Sicherheit in komplexen Umgebungen http://www.goebel-consult.de Monatliche Kolumne: http://www.cissp-gefluester.de/ Goebel Consult mit Mitglied bei http://www.7-it.de
smime.p7s
Description: S/MIME Cryptographic Signature
------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________ Shinken-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shinken-devel
