Hi,

Thanks a lot, all theses patches are commited, it's far more easy to read
now :)
I love when we delete code :)

By the way ,the last one got a typo (self in the wrapper). Did you use the
test_end_to_end.sh script? It is done for a quick test for patches. But
beware, it will "clean" installed shinken, so don't use it if you have a
real installation in your host :p


Jean



2010/12/26 Grégory Starck <g.sta...@gmail.com>

>
> had not seen directly but there was still somewhere in scheduler &
> satellitelink were pyro version was tested against..
>
> I guess it's even better with this generated patchs (that includes
> previous) that defines a getProxy method in pyro_wrapper and makes use of
> it.
>
> (master)g...@greg-laptop:~/Documents/Projets/shinken$ git format-patch
> c715cf0c2fe87d20745b6f821877fa7ea7f102a4
> 0001-pyro-make-the-test-for-pyro-version-only-1-time-inst.patch
> 0002-use-getProxy-in-pyro_wrapper-instead-of-testing.patch
> 0003-pyro_wrapper-was-misused-also-in-satellitelink.patch
> (master)g...@greg-laptop:~/Documents/Projets/shinken$
>
> stat diff:
>
> (master)g...@greg-laptop:~/Documents/Projets/shinken$ git diff --stat
>  c715cf0c2fe87d20745b6f821877fa7ea7f102a4
>  shinken/pyro_wrapper.py  |  109
> ++++++++++++++++++++--------------------------
>  shinken/satellitelink.py |   29 +++---------
>  shinken/scheduler.py     |   12 +----
>  3 files changed, 57 insertions(+), 93 deletions(-)
> (master)g...@greg-laptop:~/Documents/Projets/shinken$
>
>
> regards,
>
> greg.
>
>
>
> Le 26 décembre 2010 15:23, Grégory Starck <g.sta...@gmail.com> a écrit :
>
> Hi devel guys,
>>
>> after long time without having an eye in the code, I just see pyro_wrapper
>> define methods that for every call are testing for the pyro version and are
>> acting correspondingly.
>>
>> Here attached a small patch against latest commit I got by pull
>> (c715cf0c2fe87d20745b6f821877fa7ea7f102a4).
>>
>> The patch makes now the different methods be defined in the try: Except
>> part ; and no more multiple "if pyro_version==3: else:  "
>>
>> What do you think ?
>>
>> regards,
>>
>> Greg.
>>
>>
>
>
> ------------------------------------------------------------------------------
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment,
> and,
> should the need arise, upgrade to a full multi-node Oracle RAC database
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> Shinken-devel mailing list
> Shinken-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/shinken-devel
>
>
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel

Reply via email to