On Sun, Dec 26, 2010 at 10:03 PM, Kristoffer Moegle <
moe...@monitorarbeiter.de> wrote:

> Hi,
>
Hi,


>
> I encountered problems with windows linebreacks in configuration files
> when running python on a linux box - bad style I know.. ;-) But anyways,
> this should work. Problem is the ^M (aka \r) at the end of each line. I
> guess it has something to do with python os localization.
>
> Until now I ran into this problem in two cases:
>  - the "recourse_file" directive (v0.3) did not find the file (beacuase
> of trailing ^M)
>  - in property.py function pythonize(val) was unable to interprete
> values like "0^M" and "1^M" as Booleans
>
> Proposed patch is attached. The os check should leave everythign as is
> on windows systems - should do no harm.
>
Yes, and it's better to manage only "one style".


> Please doublecheck before comitting this one! I just tested on a Debian
> Linux (v5.0.7) box with Python (v2.5.2) and it worked for me.
>
There the automated tests for this :)


>
> Maybe someone also has a more performant solution for this one?
>
It look like a good solution, let take this :)

I'm commiting it.

Thanks a lot :)


Jean


>
> Kristoffer
>
>
> ------------------------------------------------------------------------------
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment,
> and,
> should the need arise, upgrade to a full multi-node Oracle RAC database
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> Shinken-devel mailing list
> Shinken-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/shinken-devel
>
>
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel

Reply via email to