Yes, we should keep the "fail fast" way of thinking : if we hide the root
problem, it do not crash, but it can do a even bigger problem in the running
part then, that will be harder to solve.
Jean
On Tue, Dec 28, 2010 at 10:18 AM, Hartmut Goebel <h.goe...@goebel-consult.de
> wrote:
> Hi,
>
> + if not val in _boolean_states:
> + print "Warning : '%s' is no valid boolean value. Using
> fallback '%s' instead." % (val, _boolean_fallback_state)
> + return _boolean_fallback_state
>
>
> -1 for this patch.
>
> If some text is not a boolean text, this is either a programming error
> or an error in the config file. Both have to be fixed are the origin
> place. Fall-backs are a bad solution IMHO.
>
> --
> Schönen Gruß - Regards
> Hartmut Goebel
> Dipl.-Informatiker (univ.), CISSP, CSSLP
>
> Goebel Consult
> Spezialist für IT-Sicherheit in komplexen Umgebungen
> http://www.goebel-consult.de
>
> Monatliche Kolumne: http://www.cissp-gefluester.de/
> Goebel Consult mit Mitglied bei http://www.7-it.de
>
>
>
>
> ------------------------------------------------------------------------------
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment,
> and,
> should the need arise, upgrade to a full multi-node Oracle RAC database
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> Shinken-devel mailing list
> Shinken-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/shinken-devel
>
>
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel
