2011/2/1 Grégory Starck <g.sta...@gmail.com>
> [...]
>
> Here I add a point to Jean : having checks/plugins in native python is a
> question, having perfdata results returned from theses native calls also in
> such a native python format/object is another question.. So this specific
> question can be left on the side for now I think. (although I find it honest
> for the advanced reasons).
> ( On the same matter one thing I personally quite highly don't like with
> nagios perfdata checks syntax is that the plugin checks have to return the
> min/max perfdata value thresholds in the output.. I find it's not needed
> and overcomplexity because most of the time (> 99% ?) theses values are
> always the same (and are even provided to the script by nagios itself) and
> could be handled at another higher level thus.. )
>
>
And hopefully other tools already manage all theses cases for us, like PNP
or Centreon :)
>
> [...]
> that looks like KISS .. my own opinion - for now - is that the main poller
> process should effectively import all the plugin modules during its
> configuration (or reconfig) phase(s) so that the workers have them directly
> available in easy way.. if later we see it's not good then by then we can
> move/handle the import in the workers (or else) in a more
> intelligent/smart/efficient way.
>
> having a draft picture of this could help everybody to see correctly the
> same thing ?
>
But in fact the KISS way of dummy worker mean hard work for module coders. I
think the dedicated worker by module is not more difficult to code, and will
less impact the "fork" part in fact. It only need a list of queues (one for
each module) instead of one Queue for all workers. It's not a big thing, and
with it dev can do what they want in their workers, like having a unique
connexion if they want an other things like that. And if they want they can
do a dumb module that block for each call, they do not have to manage all in
async mode for all.
I'll try to look at the poller code (in fact the common code with the
reactionner) to see the impacts and prepare tests case with this part of the
poller code so we are sure their will be no impact on the "fork" part :)
>
> Then for the Check, it will call the module and "Execute" it with the
>> Check. This module then know what to do with the command_line or maybe
>> others parameters. Of course a helper function in the Module code from
>> Grégory will help.
>>
>
> yeah :°p but side topic thus : I hope this new Module class I created
> and have used within all current shinken modules is not "bad" ; well I more
> hope that I've not broken anything (that I've not seen/detected) with it
> 'cause my personal base configuration is quite small and i could have missed
> somethings.. So do not hesitate to review some of these changes and spit
> on it ;)
>
I've seen some problems with the __import__ of the shinken-arbiter (you dev
under Windows isn't it?) but it's solved, and another very harsh : with the
Hudson daemon it seems that there problem with the os.getlogin() that I
don't understand, so I add a try/catch around and all is clear :)
> Already I'm not very sure the names I choosed for this ("basemodule.py" for
> the file and "Module" for the class) are the best ones.. I'm very
> hesitating to rename the class to "BaseModule" in order to make it different
> than the one in module.py .. wdyt ? and if you have a better name
> proposition then I'm all open to use it !
>
I think BaseModule will be better, we already have a Module one after all :)
Jean
>
>
> greg.
>
>
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Shinken-devel mailing list
> Shinken-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/shinken-devel
>
>
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel
