On Thu, Feb 3, 2011 at 12:52 PM, nap <napar...@gmail.com> wrote:
>
>
> On Thu, Feb 3, 2011 at 12:13 PM, Hartmut Goebel <
> h.goe...@goebel-consult.de> wrote:
>
>> Am 03.02.2011 11:46, schrieb nap:
>> >
>> >
>> > On Thu, Feb 3, 2011 at 11:40 AM, Hartmut Goebel
>> > <h.goe...@goebel-consult.de <mailto:h.goe...@goebel-consult.de>> wrote:
>> >
>> > Am 03.02.2011 11:32, schrieb nap:
>> > > For the sys.path, it's a bug I've got in centos 5, python2.4,
>> direct
>> > > launch (no installation, just untar/launch) with the ndo module
>> (the
>> > > module do not found the shinken lib). That's why I put this back
>> > again
>> > > an the sys.path are so hard to test :)
>> > But how could "import shinken" succeed, if the project directory
>> > is not
>> > already in PYTHONPATH?
>> >
>> > Yep, that why it's no so simple.
>> No :-) For me this is a sound signal for fixing a problem at the very
>> wrong place.
>>
>> And if you are talking about this module:
>>
>> ./shinken/modules/ndodb_mysql_broker/ndodb_broker.py
>>
>> the bug is quiet obvious and matches exactly what greg wrote a few
>> minutes ago.
>>
>> Oh, no, it's even worse: in this file, if "from shinken.db_mysql import
>> DBMysql" fails for *any* reason, you are falling back to "from db_mysql
>> import DBMysql".
>>
>> a) This should be restricted to ImportErrors only
>> b) This fall back should be removed completely, since its a sign of
>> problems rooting somewhere else.
>>
> Yes, it's this one.
>
> The problem is that to reproduce it, I need to crash my prod, and it's a no
> way of course.
>
> I'll duplicate it, but yes, it hide something. If you can reproduce it
> before me, feel free to fix it :)
>
I quick crash it, and the problem occurs when we use the direct launch
method without the .sh scripts. So in this situation, the shinken lib is not
accessible without the path.append. In fact, there were a
sys.path.append('.') for Pyro4 testing, and this one make the first import
shinken.blabla work, but when we change the pwd, all was lost ( '.' was in
/var, no more in the source directory).
So the solution is to remove the append of '.' and delete the append if
shinken work, because it will be indeed useless.
Now it will be easier for namespaces so, we will do not fear any sys.path
problems. And it prove one time again that hacks like the '.' is not a good
thing....
Jean
>
>
> Jean
>
>
>>
>> --
>>
>> Schönen Gruß - Regards
>> Hartmut Goebel
>> Dipl.-Informatiker (univ.), CISSP, CSSLP
>>
>> Goebel Consult
>> Spezialist für IT-Sicherheit in komplexen Umgebungen
>> http://www.goebel-consult.de/blog/
>>
>> Monatliche Kolumne: http://www.cissp-gefluester.de/
>> Goebel Consult mit Mitglied bei http://www.7-it.de
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
>> Finally, a world-class log management solution at an even better
>> price-free!
>> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
>> February 28th, so secure your free ArcSight Logger TODAY!
>> http://p.sf.net/sfu/arcsight-sfd2d
>> _______________________________________________
>> Shinken-devel mailing list
>> Shinken-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/shinken-devel
>>
>>
>
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel