[
https://issues.apache.org/jira/browse/SHIRO-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770150#action_12770150
]
Les Hazlewood commented on SHIRO-96:
------------------------------------
Interesting - I noticed that when calling addToStrongReferences in the get
method, if you call get 100 times with the same key, it will effectively
expunge any other strong reference and the queue will contain 100 entries, all
with the same memory pointer. Not really desirable.
I think we might need to remove the addToStrongReferences method call from the
get method and call trimStrongReferencesIfNecessary in any method that modifies
the underlying Map. I don't know why Heinz and Sydney did that in their
initial implementation - I'll have to ask them.
> Add meaningful integration tests to assert key web functionality
> ----------------------------------------------------------------
>
> Key: SHIRO-96
> URL: https://issues.apache.org/jira/browse/SHIRO-96
> Project: Shiro
> Issue Type: Test
> Components: Authentication (log-in)
> Affects Versions: 1.0
> Environment: any
> Reporter: Kalle Korhonen
> Fix For: 1.0
>
> Attachments: integration-tests.patch
>
>
> Related to SHIRO-93 (but you closed it already - could have re-opened as
> well). Assert login/logout and remember me functionality. Also updating
> htmlunit to newly released 2.6. Note that tests revealed an interesting
> thread-safety issue: sometimes
> getAuthorizationCache().get(upToken.getUsername()); on line 141 of
> SimpleAccountRealm returned null, causing the authentication to fail. It
> happened much frequently when I was running the test via Eclipse, but
> couldn't get it to run when running via Maven. I took an initial look at the
> CacheManager and didn't follow through completely, but it looked like that a
> map initialization somewhere may not have been synchronized. Note that these
> tests run considerably faster than if a human was using a browser but
> otherwise they don't semantically do anything else different. A patch to
> follow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
