Le lundi 24 mai 2010 19:23:14, Brian Demers a écrit :
> Also,  After taking a very quick look at the patch.
> 
> This requires a dependency on bouncycastle ( sort of the obvious choice ).
>  But this means the core will depend on bouncycastle.

Only shiro-web would depend on bouncy.
 
> Les, what is the _policy_ for this type of dependency,   I don't think it
> should be a core dep.
> 
> A couple of options are:
> 1.) Push this realm to its own sub-module.
> 2.) Mark the dep as optional/provided/etc ( not a big fan of this one )
> 3.) Nothing, leave it as a dep

Whatever the policy is fine for me, once stated I'll refactor to submit another 
patch.

/Paul


Reply via email to