On Mon, Jul 26, 2010 at 11:14 PM, Kalle Korhonen <[email protected]> wrote: > For completeness, I think we should add: > void checkRoles(String... roleIdentifiers) throws AuthorizationException;
I agree that this should be there - it is more convenient than creating a wrapper collection. > I'd rather deprecate both checkXXX(String) and checkXXXs(Collection) > and leave only checkXXXs(String...) - I don't see value for the > additional methods but not sure if cleaning that up is worth the > effort. I'm assuming you mean for the checkRoles methods only? We can't have string-only checkPermissions methods, since people need the ability to check type-safe Permission instances as well. My initial feeling is to add the checkRoles(String... roleIdentifiers) method and not remove the others, until say, a 2.0 release. They're fairly harmless as is and my personal desire is to refrain from making backward-incompatible changes in as much as is possible. Just my .02, Les
