Steven Jan Springl wrote:
> On Friday 07 December 2007 00:26, Tom Eastep wrote:
>> Shorewall 4.1.2 is now available for testing.
> 
> Tom;
> 
> Nat entry:
>       
>       10.1.1.1  eth0:  192.168.12.1
> 
> When compiled with Shorewall-perl, 10.1.1.1 is added as an alias to eth0.
> When compiled with Shorewall-shell it is not added as an alias.
> 
> Having read the shorewall-nat man page, I was not expecting the alias to be 
> added.
> 
> ADD_IP_ALIASES=Yes is set in shorewall.conf

This problem also occurs in 4.0.6. Patch attached.

-Tom
-- 
Tom Eastep    \ Nothing is foolproof to a sufficiently talented fool
Shoreline,     \ http://shorewall.net
Washington USA  \ [EMAIL PROTECTED]
PGP Public Key   \ https://lists.shorewall.net/teastep.pgp.key
Index: Shorewall/Nat.pm
===================================================================
--- Shorewall/Nat.pm	(revision 7861)
+++ Shorewall/Nat.pm	(working copy)
@@ -372,14 +372,11 @@
     fatal_error "Invalid nat file entry" unless defined $interface && defined $internal;
 
     if ( $add_ip_aliases ) {
-	if ( $interface =~ s/:$// ) {
+	if ( defined( $alias ) && $alias eq '' ) {
 	    $add_ip_aliases = '';
 	} else {
-	    my ( $iface , undef ) = split /:/, $interface;
-	    emit "del_ip_addr $external $iface" unless $config{RETAIN_ALIASES};
+	    emit "del_ip_addr $external $interface" unless $config{RETAIN_ALIASES};
 	}
-    } else {
-	$interface =~ s/:$//;
     }
 
     validate_nat_column 'ALL INTERFACES', \$allints;

Attachment: signature.asc
Description: OpenPGP digital signature

-------------------------------------------------------------------------
SF.Net email is sponsored by: 
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to