On 7/24/10 11:27 AM, Steven Jan Springl wrote:
> Tom;
> 
> When the following rule is coded:
> 
> ADD(set1:src,dst)   lan  brd  tcp  80
> 
> "shorewall start" produces the error message:
> 
> ERROR: Unknown action (ADD(set1) : .......

The attached patch should fix you up (Once you replace 'set1' with '+set1').

Thanks,
-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Actions.pm 
b/Shorewall/Perl/Shorewall/Actions.pm
index da28b4d..f033577 100644
--- a/Shorewall/Perl/Shorewall/Actions.pm
+++ b/Shorewall/Perl/Shorewall/Actions.pm
@@ -190,7 +190,7 @@ sub split_action ( $ ) {
     #
     # The param may contain one or more ':' characters
     #
-    if ( $action =~ /^([^(:]+\(.*?\))(:(.*))$/ ) {
+    if ( $action =~ /^([^(:]+\(.*?\))(:(.*))?$/ ) {
        $target = $1;
        $action = $2 ? $3 : '';
        $max    = 2;

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to