On 12/21/10 12:37 PM, Steven Jan Springl wrote:
> Tom
> 
> In the attached minimal config, action F2 calls itself, which results in 
> the "Optimizing ruleset" phase going into an endless loop.

This fixes it.

Thanks Steven,
-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Rules.pm 
b/Shorewall/Perl/Shorewall/Rules.pm
index 655aa45..6bc8d5c 100644
--- a/Shorewall/Perl/Shorewall/Rules.pm
+++ b/Shorewall/Perl/Shorewall/Rules.pm
@@ -293,8 +293,6 @@ sub process_actions1() {
                next;
            }
 
-           $targets{$action} = ACTION;
-
            fatal_error "Invalid Action Name ($action)" unless "\L$action" =~ 
/^[a-z]\w*$/;
 
            new_action $action;
@@ -335,6 +333,8 @@ sub process_actions1() {
            }
 
            pop_open;
+
+           $targets{$action} = ACTION;
        }
     }
 }

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Forrester recently released a report on the Return on Investment (ROI) of
Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even
within 7 months.  Over 3 million businesses have gone Google with Google Apps:
an online email calendar, and document program that's accessible from your 
browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to