On 1/3/11 11:49 AM, Steven Jan Springl wrote:

> If I code the following rules file entry:
> 
> extensions(DROP,length,ne,100:200)  lan  tst  tcp  80
> 
> In the extensions script @params contains:
> 
>       DROP length ne 100
> 
> Is this expected?

No.

> 
> I have attached a minimal config. to demonstrate this.
>   

Patch attached. I've uploaded RC1 which also requires this patch.

Thanks, Steven!
-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________
--- Rules.pm.orig       2011-01-03 12:08:34.000000000 -0800
+++ Rules.pm    2011-01-03 12:08:44.000000000 -0800
@@ -260,7 +260,7 @@
 sub createactionchain( $ ) {
     my $normalized = shift;
 
-    my ( $target, $level, $tag, $param ) = split /:/, $normalized;
+    my ( $target, $level, $tag, $param ) = split /:/, $normalized, 4;
 
     assert( defined $param );
 
@@ -611,7 +611,7 @@
 sub process_action( $) {
     my $chainref = shift;
     my $wholeaction = $chainref->{action};
-    my ( $action, $level, $tag, $param ) = split /:/, $wholeaction;
+    my ( $action, $level, $tag, $param ) = split /:/, $wholeaction, 4;
 
     if ( $targets{$action} & BUILTIN ) {
        $level = '' if $level =~ /none!?/;
@@ -884,7 +884,7 @@
     my $normalized_target;
     my $normalized_action;
  
-    ( $inaction, undef, undef, undef ) = split /:/, $normalized_action = 
$chainref->{action} if defined $chainref;
+    ( $inaction, undef, undef, undef ) = split /:/, $normalized_action = 
$chainref->{action}, 4 if defined $chainref;
 
     $param = '' unless defined $param;
 

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to