On 3/16/11 3:31 PM, Steven Jan Springl wrote: > Tom > > A few minor issues with shorewall.conf parameter TC_PRIOMAP. > > If a value has a decimal point: > > TC_PRIOMAP="2.1 3 3 3 2 3 1 1 2 2 2 2 2 2 2 2" > > The following error messages are produced: > > Illegal "priomap" element > ERROR: Command "tc qdisc add dev eth0 root handle 1: prio bands 3 priomap 1.1 > 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1" Failed > > ------------------------------------------------------------------------------------------------------------------------------- > > If a value is negative: > > TC_PRIOMAP="-1 3 3 3 2 3 1 1 2 2 2 2 2 2 2 2" > > The following error messages are produced: > > "priomap" element is out of bands > ERROR: Command "tc qdisc add dev eth0 root handle 1: prio bands 3 priomap -2 > 2 > 2 2 1 2 0 0 1 1 1 1 1 1 1 1" Failed > > ------------------------------------------------------------------------------------------------------------------------------- > > If the closing " is missing: > > TC_PRIOMAP="2 3 3 3 2 3 1 1 2 2 2 2 2 2 2 2 > > The following error messages are produced: > > "priomap" element is out of bands > ERROR: Command "tc qdisc add dev eth0 root handle 1: prio bands 3 priomap -1 > 2 > 2 2 1 2 0 0 1 1 1 1 1 1 1 1" Failed
Steven,
I couldn't reproduce the last problem -- I kept getting /etc/shorewall
/shorewall.conf: 63: Syntax error: Unterminated quoted string
But the attached patch corrects the other two.
Thanks!
-Tom
--
Tom Eastep \ When I die, I want to go like my Grandfather who
Shoreline, \ died peacefully in his sleep. Not screaming like
Washington, USA \ all of the passengers in his car
http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Config.pm
b/Shorewall/Perl/Shorewall/Config.pm
index d537a8f..4e9fbfb 100644
--- a/Shorewall/Perl/Shorewall/Config.pm
+++ b/Shorewall/Perl/Shorewall/Config.pm
@@ -3385,7 +3385,7 @@ sub get_configuration( $ ) {
my @priomap = split ' ',$val;
fatal_error "Invalid TC_PRIOMAP ($val)" unless @priomap == 16;
for ( @priomap ) {
- fatal_error "Invalid TC_PRIOMAP entry ($_)" unless /[1-3]/;
+ fatal_error "Invalid TC_PRIOMAP entry ($_)" unless /^[1-3]$/;
$_--;
}
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
