On 7/20/11 4:56 PM, Steven Jan Springl wrote: > Sorry, I missed that. > > If I change the rule to: > > LOG:LOGMARK(1,0) lan fw tcp 100 > > The following message are produced: > > Use of uninitialized value $sublevel in pattern match (m//) > at /usr/share/shorewall/Shorewall/Config.pm line 2152, <$currentfile> line > 18. > > Use of uninitialized value $sublevel in concatenation (.) or string > at /usr/share/shorewall/Shorewall/Config.pm line 2159, <$currentfile> line > 18. > > iptables-restore v1.4.11.1: LOGMARK: Bad value for "--log-level" > option: "--log-prefix"
Steven, The attached patch eliminates that problem. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Config.pm
b/Shorewall/Perl/Shorewall/Config.pm
index a275b2f..cb10f37 100644
--- a/Shorewall/Perl/Shorewall/Config.pm
+++ b/Shorewall/Perl/Shorewall/Config.pm
@@ -2149,7 +2149,7 @@ sub validate_level( $ ) {
if ( $1 ) {
$sublevel = $validlevels{$sublevel} unless $sublevel =~
/^[0-7]$/;
- level_error( $level ) unless defined $sublevel =~ /^[0-7]$/;
+ level_error( $level ) unless defined $sublevel && $sublevel =~
/^[0-7]$/;
} else {
$sublevel = 6; # info
}
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ 5 Ways to Improve & Secure Unified Communications Unified Communications promises greater efficiencies for business. UC can improve internal communications as well as offer faster, more efficient ways to interact with customers and streamline customer service. Learn more! http://www.accelacomm.com/jaw/sfnl/114/51426253/
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
