On Mon, 2011-07-25 at 16:45 +0100, Steven Jan Springl wrote: > In the attached config. rule: > > Broadcast(ACCEPTX,audit) all all tcp 100 > > generates the following iptables rule: > > -A %Broadcast -m addrtype --dst-type BROADCAST -j AUDIT --type acceptx > > which produces the following error message: > > iptables-restore v1.4.11.1: Bad action type value "acceptx"
Steven, I seem to be making a career out of correcting this one defect. Patch attached. Thanks, -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/action.Broadcast b/Shorewall/action.Broadcast index 7c85a07..38fe75d 100644 --- a/Shorewall/action.Broadcast +++ b/Shorewall/action.Broadcast @@ -40,7 +40,7 @@ use Shorewall::Chains; my ( $action, $audit ) = get_action_params( 2 ); fatal_error "Invalid parameter ($audit) to action Broadcast" if supplied $audit && $audit ne 'audit'; -fatal_error "Invalid parameter ($action) to action Broadcast" unless $action =~ /^ACCEPT|DROP|REJECT$/; +fatal_error "Invalid parameter ($action) to action Broadcast" unless $action =~ /^(?:ACCEPT|DROP|REJECT)$/; my $chainref = get_action_chain; my ( $level, $tag ) = get_action_logging; diff --git a/Shorewall/action.Invalid b/Shorewall/action.Invalid index a8aabbb..7cae452 100644 --- a/Shorewall/action.Invalid +++ b/Shorewall/action.Invalid @@ -40,7 +40,7 @@ use Shorewall::Chains; my ( $action, $audit ) = get_action_params( 2 ); fatal_error "Invalid parameter ($audit) to action Invalid" if supplied $audit && $audit ne 'audit'; -fatal_error "Invalid parameter ($action) to action Invalid" unless $action =~ /^ACCEPT|DROP|REJECT$/; +fatal_error "Invalid parameter ($action) to action Invalid" unless $action =~ /^(?:ACCEPT|DROP|REJECT)$/; my $chainref = get_action_chain; my ( $level, $tag ) = get_action_logging; diff --git a/Shorewall/action.NotSyn b/Shorewall/action.NotSyn index ae2226f..afd778d 100644 --- a/Shorewall/action.NotSyn +++ b/Shorewall/action.NotSyn @@ -40,7 +40,7 @@ use Shorewall::Chains; my ( $action, $audit ) = get_action_params( 2 ); fatal_error "Invalid parameter ($audit) to action NotSyn" if supplied $audit && $audit ne 'audit'; -fatal_error "Invalid parameter ($action) to action NotSyn" unless $action =~ /^ACCEPT|DROP|REJECT$/; +fatal_error "Invalid parameter ($action) to action NotSyn" unless $action =~ /^(?:ACCEPT|DROP|REJECT)$/; my $chainref = get_action_chain; my ( $level, $tag ) = get_action_logging;
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ Storage Efficiency Calculator This modeling tool is based on patent-pending intellectual property that has been used successfully in hundreds of IBM storage optimization engage- ments, worldwide. Store less, Store more with what you own, Move data to the right place. Try It Now! http://www.accelacomm.com/jaw/sfnl/114/51427378/
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
