On Thu, 2011-07-28 at 22:27 +0100, Steven Jan Springl wrote:

> Tom
> 
> If shorewall.conf does not contain an entry for TCP_FLAGS_DISPOSITION the 
> following message is produced:
> 
> Use of uninitialized value $val in pattern match (m//) 
> at /usr/share/shorewall/Shorewall/Config.pm line 3711.
> 
> This also applies to shorewall6.conf.
> 


Steven,

This seems to fix it.

Thanks,
-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________

diff --git a/Shorewall/Perl/Shorewall/Config.pm b/Shorewall/Perl/Shorewall/Config.pm
index 26327c8..481881b 100644
--- a/Shorewall/Perl/Shorewall/Config.pm
+++ b/Shorewall/Perl/Shorewall/Config.pm
@@ -3705,7 +3705,7 @@ sub get_configuration( $$$ ) {
     if ( $val = $config{TCP_FLAGS_DISPOSITION} ) {
 	fatal_error "Invalid value ($config{TCP_FLAGS_DISPOSITION}) for TCP_FLAGS_DISPOSITION" unless $val =~ /^(?:(?:A_)?(?:REJECT|DROP)|ACCEPT)$/;
     } else {
-	$config{TCP_FLAGS_DISPOSITION} = 'DROP';
+	$val = $config{TCP_FLAGS_DISPOSITION} = 'DROP';
     }
 
     require_capability 'AUDIT_TARGET' , "TCP_FLAGS_DISPOSITION=$val", 's' if $val =~ /^A_/;

Attachment: signature.asc
Description: This is a digitally signed message part

------------------------------------------------------------------------------
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to