On 06/14/2012 03:03 PM, Steven Jan Springl wrote:

The following tcdevices entry:

eth0  - 384kbit classify,linklayer=adsl,mtu=1024,mpu=1024,tsize=512,overhead=0

produces the following error messages:

Error: duplicate "mpu": "512" is the second value.

ERROR: Command "tc qdisc add dev eth0 stab linklayer adsl overhead 0 mtu 1024
mpu 1024 mpu 512 root handle 1: htb default 110 r2q 5" Failed

The attached patch should eliminate this error.

Thanks, Steven

-Tom
--
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Tc.pm b/Shorewall/Perl/Shorewall/Tc.pm
index 45dbdfd..7302d2b 100644
--- a/Shorewall/Perl/Shorewall/Tc.pm
+++ b/Shorewall/Perl/Shorewall/Tc.pm
@@ -1800,9 +1800,9 @@ sub process_traffic_shaping() {
 
 	    if ( $devref->{linklayer} ) {
 		$stab =  "stab linklayer $devref->{linklayer} overhead $devref->{overhead} ";
-		$stab .= "mtu $devref->{mtu} "   if $devref->{mtu};
-		$stab .= "mpu $devref->{mpu} "   if $devref->{mpu};
-		$stab .= "mpu $devref->{tsize} " if $devref->{tsize};
+		$stab .= "mtu $devref->{mtu} "     if $devref->{mtu};
+		$stab .= "mpu $devref->{mpu} "     if $devref->{mpu};
+		$stab .= "tsize $devref->{tsize} " if $devref->{tsize};
 	    } else {
 		$stab = '';
 	    }
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to