Tom Eastep wrote:
>> Sort of - you need to include the same changes in "stop()" as well. In
>> "setstatedir()" the "firewall" compilation "if" block isn't needed either.
>>
>
> This should remove redundant compilation and handle stop as well. Apply
> your patch on top of it.
>
Two additional (minor) issues: Currently, if I have
PRODUCTS="mickey-mouse" in /etc/sysconfig/shorewall-init, the init.d
script completes and tells me that everything is OK. The outcome is
exactly the same if the conditional compilation fails for some reason
(regardless of whether the old "firewall" is present or not). I think
that's wrong and the init.d script should return a failure if:
1. "PRODUCTS" has not been processed for whatever reason;
2. "shorewall compile -c" fails; or
3. "firewall" does not exist.
Finally, in init.<distro>.sh, the usage message should really be "Usage:
$0" or "Usage: shorewall-init" instead of "Usage:
/etc/init.d/shorewall-init {...}"
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel
