On 1/15/2014 3:55 PM, Thomas D. wrote: > Hi, > > 1) 'man shorewall' prints > > [...] > > shorewall [trace|debug] [-options] dump [-x] [-l] [-m] > > [...] > > dump > Produces a verbose report about the firewall configuration for the > purpose of problem analysis. > > The -x option causes actual packet and byte counts to be displayed. > Without that option, these counts are > abbreviated. The -m option causes any MAC addresses included in > Shorewall log messages to be displayed. > > The -l option causes the rule number for each Netfilter rule to be > displayed. > > [...] > > but > > # shorewall help > > doesn't list "-l" or "-m" for "dump" > > and I don't see a difference between the output of > > # shorewall dump -x > > and > > # shorewall dump -x -l > > > 2) "man shorewall" prints > > SHOREWALL(8) [FIXME: manual] SHOREWALL(8) > ^^^^^^^^^^^^^^^ > | > ^ > | > > in the header. > > > Tested with shorewall v4.5.21.5. >
Here's a patch that fixes the output of 'dump'. The problem with the output of 'man' is a consequence of the tool chain we use and is present in all of the manpages. It doesn't affect the usability of the manpages and no one has volunteered to fix it. Thanks, -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall-core/lib.cli b/Shorewall-core/lib.cli
index 63b5619..6604702 100644
--- a/Shorewall-core/lib.cli
+++ b/Shorewall-core/lib.cli
@@ -1546,7 +1546,7 @@ do_dump_command() {
}
dump_command() {
- do_dump_command | dump_filter
+ do_dump_command $@ | dump_filter
}
#
@@ -3415,7 +3415,7 @@ usage() # $1 = exit status
echo " delete <interface>[:<host-list>] ... <zone>"
echo " disable <interface>"
echo " drop <address> ..."
- echo " dump [ -x ]"
+ echo " dump [ -x ] [-l]"
echo " enable <interface>"
echo " forget [ <file name> ]"
echo " help"
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
