Hi,

in every shorewall service file we have

  EnvironmentFile=-/etc/sysconfig/shorewall

The "-" before the file makes the file optional, from
http://www.freedesktop.org/software/systemd/man/systemd.exec.html:

> The argument passed should be an absolute filename or wildcard
> expression, optionally prefixed with "-", which indicates that if the
> file does not exist, it will not be read and no error or warning
> message is logged. This option may be specified more than once in
> which case all specified files are read. If the empty string is
> assigned to this option, the list of file to read is reset, all prior
> assignments have no effect.

For me it is like using a not initialized variable... something you
normally try to avoid.

In this special case I don't expect any real problems, however I am
suggesting to remove the "-"...

What do you think?


-Thomas

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to